Recent posts

#31

Bugs! / back slash shold not be remove...

Last post by ColinM - 07.06.2025 21:04:04

Tom
I did mean that the backslash should not be removed so the image is shown
Colin

#32

Bugs! / Re: Components > jDownloads > ...

Last post by Tom68 - 07.06.2025 17:30:46

Colin,

Actually, here it is just the other way round. With the backslash the character is intepreted and the files-lines symbol is displayed. Without the backslash only the code f15c is displayed. You can easily verify this, with a website with corresponding css code and a browser.

Regards
Tom

#33

Bugs! / font awesome

Last post by ColinM - 07.06.2025 16:51:46

Tom
My understanding of the backslash character is that the characters following the backslash, up to a space character, are to be shown explicitly and not interpreted. So in your case you wanted to see F15C in the text shown on the screen
Please let me know
 
Colin

#34

Bugs! / Re: admin/src/View/Cssedit/Htm...

Last post by Tom68 - 07.06.2025 16:11:54

Supplement:

The COM_JDOWNLOADS_BACKEND_EDIT_LANG_CSS_FILE_WRITABLE_INFO notes in the following 2 files are inconsistent and the recommended file permissions are incorrect.

admin/language/en-GB/en-GB.com_jdownloads.ini

COM_JDOWNLOADS_BACKEND_EDIT_LANG_CSS_FILE_WRITABLE_INFO="In order to save new settings, the file must be writable. You have to change the access rights of the file to 'CHMOD 0755'. See FAQ on setting file access rights."

admin/language/de-DE/de-DE.com_jdownloads.ini

COM_JDOWNLOADS_BACKEND_EDIT_LANG_CSS_FILE_WRITABLE_INFO="Um Änderungen an der Datei speichern zu können, muss diese beschreibbar sein. Ändern Sie mit einem FTP-Programm die Zugriffsrechte für diese Datei auf CHMOD 0766."

Rather than 0755 (-rwxr-xr-x) or 0766 (-rwxrw-rw), 0644 (-rw-r--r--) should be sufficient for a css file.

Regards
Tom

#35

Bugs! / Re: admin/src/Table/DownloadTa...

Last post by ColinM - 07.06.2025 16:05:10

Tom
Thanks.  I am making a list of these.  The items you are finding are hangovers from very much earlier jD versions when such permissions seemed to be required.
Generally these days we concentrate on items that cause jD to fail or 'misbehave'. When we have one of these or sufficient enhancements are accumulated then a new release is made.  I suspect the Content Plugin may well turnout to be  such a case
Best wishes
Colin.

#36

Bugs! / Components > jDownloads > Layo...

Last post by Tom68 - 07.06.2025 15:59:48

Joomla 5.3.1
jDownloads 4.0.47

Colin & Arno,

It seems the jDownloads editor that is called up in the backend under "Components > jDownloads > Layouts > CSS Files" removes backslashes from the css code. The following css code is part of my "jdownloads_custom.css":

Code Select Expand

/* replace bullet */

.com-content-article__body ul{
    list-style-type: none;
}

.com-content-article__body li:before {   
    font-family: "Font Awesome 6 Free";
    content: '\f15c';
    margin:0 0.65em 0 -1.4em;
}

By means of this code I replace the default bullet by the files-lines character of font awesome 6 free. However, when the editor is left by clicking "Save & Close" the backslash before "f15c" gets removed. As a result "F15C" is displayed on the corresponding webpage rather than the files-lines character.

Regards
Tom

#37

Bugs! / admin/src/Table/DownloadTable....

Last post by Tom68 - 07.06.2025 15:35:41

Joomla 5.3.1
jDownloads 4.0.47

Colin & Arno,

I found another permission issue in the file "admin/src/Table/DownloadTable.php: 1134-1143".

Code Select Expand

                                    if (extension_loaded('gd') && function_exists('gd_info')) {
                                        // move okay - create now thumbnail
                                        $x = JDownloadsHelper::create_new_thumb($upload_dir.$filename, $filename);       
                                        // set correct chmod
                                        @chmod($upload_dir.$filename, 0655);
                                        // move ok - set new file name as selected
                                        $images[] = $filename;
                                    } else {
                                        Factory::getApplication()->enqueueMessage( Text::_('COM_JDOWNLOADS_ERROR_CAN_NOT_CREATE_THUMB_IMAGE'), 'warning');
                                    }

Why should a thumbnail image file require 0655 (-rw-r-xr-x), i.e. execute permissions for both group and others? I think 0644 (-rw-r--r--) should be perfectly sufficient.

Regards
Tom

#38

Bugs! / admin/src/View/Cssedit/HtmlVie...

Last post by Tom68 - 06.06.2025 17:30:48

Joomla 5.3.1
jDownloads 4.0.47

Colin & Arno,

There are 4 wrong permission statements included with the file "admin/src/View/Cssedit/HtmlView.php: 52-62" of jDownloads 4.0.47

Code Select Expand

        $css_file = JPATH_SITE.'/components/com_jdownloads/assets/css/jdownloads_fe.css';
        @chmod ($css_file, 0755);

        $css_file2 = JPATH_SITE.'/components/com_jdownloads/assets/css/jdownloads_buttons.css';
        @chmod ($css_file2, 0755);
       
        $css_file3 = JPATH_SITE.'/components/com_jdownloads/assets/css/jdownloads_custom.css';
        @chmod ($css_file3, 0755);
       
        $css_file4 = JPATH_SITE.'/components/com_jdownloads/assets/css/jdownloads_fe_rtl.css';
        @chmod ($css_file4, 0755);

When in the Joomla backend "Components > jDownloads > Layouts > CSS Files" is selected (regardless, if any CSS file is saved or editing is cancelled), the respective files get execute permission:

-rwxr-xr-x 1  4726  6. Jun 16:55 jdownloads_buttons.css*
-rwxr-xr-x 1  1032  1. Jun 12:52 jdownloads_custom.css*
-rwxr-xr-x 1 38440  6. Jun 16:55 jdownloads_fe.css*
-rwxr-xr-x 1  6334  6. Jun 16:55 jdownloads_fe_rtl.css*

Please replace the permissions "0755" by "0644". This is safer and still allows the files to be edited.

Thanks & Regards
Tom

#39

Suggestions - Feature Request / Pre-process smart search resul...

Last post by Tom68 - 05.06.2025 21:08:51

In jD 4.0.47 the results of a smart search are not pre-processed with the function "onContentPrepare" of the Content Plugin. In fact, I did not find any trigger in the code of jD 4.0.47 to accomplish this. As a result, the search results contain unresolved {jd_file} code.

I would highly appreciate, if this missing feature could be added.

Thanks & Regards
Tom

#40

Suggestions - Feature Request / Re: Update file icons to the l...

Last post by ColinM - 05.06.2025 17:29:54

Hi
Am also making some more icons as per your suggestion. So far have done bz2 and hqkx.  Will send to Arno ti=o u=include in next upade .  Whwn done I will send yo a PM the the new imagesColin