Joomla 5.3.1
jDownloads 4.0.47
Colin & Arno,
There are 4 wrong permission statements included with the file "admin/src/View/Cssedit/HtmlView.php: 52-62" of jDownloads 4.0.47
$css_file = JPATH_SITE.'/components/com_jdownloads/assets/css/jdownloads_fe.css';
@chmod ($css_file, 0755);
$css_file2 = JPATH_SITE.'/components/com_jdownloads/assets/css/jdownloads_buttons.css';
@chmod ($css_file2, 0755);
$css_file3 = JPATH_SITE.'/components/com_jdownloads/assets/css/jdownloads_custom.css';
@chmod ($css_file3, 0755);
$css_file4 = JPATH_SITE.'/components/com_jdownloads/assets/css/jdownloads_fe_rtl.css';
@chmod ($css_file4, 0755);
When in the Joomla backend "Components > jDownloads > Layouts > CSS Files" is selected (regardless, if any CSS file is saved or editing is cancelled), the respective files get execute permission:
Quote-rwxr-xr-x 1 4726 6. Jun 16:55 jdownloads_buttons.css*
-rwxr-xr-x 1 1032 1. Jun 12:52 jdownloads_custom.css*
-rwxr-xr-x 1 38440 6. Jun 16:55 jdownloads_fe.css*
-rwxr-xr-x 1 6334 6. Jun 16:55 jdownloads_fe_rtl.css*
Please replace the permissions "0755" by "0644". This is safer and still allows the files to be edited.
Thanks & Regards
Tom
Supplement:
The COM_JDOWNLOADS_BACKEND_EDIT_LANG_CSS_FILE_WRITABLE_INFO notes in the following 2 files are inconsistent and the recommended file permissions are incorrect.
admin/language/en-GB/en-GB.com_jdownloads.ini
QuoteCOM_JDOWNLOADS_BACKEND_EDIT_LANG_CSS_FILE_WRITABLE_INFO="In order to save new settings, the file must be writable. You have to change the access rights of the file to 'CHMOD 0755'. See FAQ on setting file access rights."
admin/language/de-DE/de-DE.com_jdownloads.ini
QuoteCOM_JDOWNLOADS_BACKEND_EDIT_LANG_CSS_FILE_WRITABLE_INFO="Um Änderungen an der Datei speichern zu können, muss diese beschreibbar sein. Ändern Sie mit einem FTP-Programm die Zugriffsrechte für diese Datei auf CHMOD 0766."
Rather than 0755 (-rwxr-xr-x) or 0766 (-rwxrw-rw), 0644 (-rw-r--r--) should be sufficient for a css file.
Regards
Tom
Hi Tom,
thanks for the hints. ;)
I will check and fix it shortly.
I just installed jD 4.0.49 and noticed that the wrong permissions are still included. :-[
Regards
Tom
Ok. Sorry. :-\
But is now really part from next release!
I just installed jDownloads 4.0.50 ... and found that the promised correction is still not included.
Honestly, I do not know, what I am supposed to think about this issue.
Regards
Tom
QuoteHonestly, I do not know, what I am supposed to think about this issue.
In this case, I would think that it was a mistake on my part. At that point, I was working on two different versions at the same time, so mistakes can happen.