jDownloads Support Forum

jDownloads for Joomla 4.x and 5.x => jDownloads 4.0 => Bugs! => Topic started by: TJoomla on 17.09.2024 05:01:24

Title: icomoon symbols for Overview/Search/Up/Add not showing
Post by: TJoomla on 17.09.2024 05:01:24
The icomoon symbols for Overview/Search/Up/Add are not showing for some views. I figured it out. It's because of Remove empty HTML tags. The symbols can be shown with Remove empty HTML tags enabled by making the HTML tag inserted for them non-empty:

-        $span_home_symbol   = '<span class="icon-home-2 jd-menu-icon"> </span>';
+        $span_home_symbol   = '<span class="icon-home-2 jd-menu-icon">&#160;</span>';

I attached a patch file with all the cases.

Thank you,
Tim


Joomla Version: 4.4.8 (new install)
jDownloads 4.0.45 Stable (new install)
PHP Version: 8.3
Standard backend template
Title: Icomoon
Post by: ColinM on 19.09.2024 11:42:34
Hi
To enable Icomoon font go to Jd Options Pictures and Buttons tab
Scroll down to 'Use Icomoon font' and set to yes or no.

The attached Pictures show the result

I am using jD 4.0.45 with PHP 8.2.23 and Joomla 5.1.4
Colin
Title: Re: icomoon symbols for Overview/Search/Up/Add not showing
Post by: TJoomla on 19.09.2024 18:24:36
Yup.

However, in some views, this does not work.

It took hours for me to track it down.

It is because I have Remove Empty HTML tags set, because I like the really short status bars sometimes and without Remove Empty set, they have these funny little marks.

The icomoon font symbols are placed in these buttons using this HTML:
<span class="icon-home-2 jd-menu-icon"> </span>
where the CSS class causes the icon to show up. This is an empty HTML tag.

I fixed it by putting a binary non-breaking space, as Arno recommends somewhere to allow an empty HTML tag when Remove Empty is set:
<span class="icon-home-2 jd-menu-icon">&#160;</span>

I'm pretty good as sh, so I did this fix in 20 places, 5 different files, with a 1 line sh. I attached a patch with these fixed files to the initial post of this bug report.

Thank you,
Tim
Title: icomoon
Post by: ColinM on 20.09.2024 11:06:23
Hi
I have replicated your findings in regard to 'Remove EmptyHTML' setting in Front End
and setting  Icomoon Font in Pics & Buttons

Colin