jDownloadsownloads.com


Author Topic: Preview of PDF files?  (Read 2327 times)

0 Members and 1 Guest are viewing this topic.

Offline ColinM

  • Moderator
  • *
  • Posts: 3.979
Re: Preview of PDF files?
« Reply #15 on: 22.08.2019 13:05:50 »
Hi
Yes a distinct improvement.  What I would suggest initially is to make this as a component override - could you do this ?  I would test out and produce some examples, document and so on. The size parametersmight need to be max-size type or percentages which we could experiment with.

Adding in the pdfjs viewer as part of the jD install would obviously be a good idea and simplify matters.  But as present we are working very much on the next major release of jD (called v3.9) so in my opinion that would be the best time to include the viewer in the jD installation. - and make the facility a feature?   

Users might want to just show a section of the pdf so is it a possiblility to specify the number of pages or even better the page range?  At this time it looks like 4 or 5 parameters in the Back End would be needed for inclusion in the jD config.xml file, probably the Specials section.First "Do you wish to use embedded pdf viewer?" with a Yes/No selection The Yes would then reveal the pages and size parameters. 

I would suggest a suitable place to load the viewer file would be in a new directory in the components/com_jdownloads/assets called say pdfjs although perhaps it could go into the existing js directory.
What do you think?Colin



Offline EURRWebmaater

  • Newbie
  • *
  • Posts: 15
Re: Preview of PDF files?
« Reply #16 on: 25.08.2019 15:43:20 »
I tried to make an override as instructed here: https://docs.joomla.org/How_to_override_the_output_from_the_Joomla!_core
But it didn`t work.

I made an zip with al the files that i have adjusted  and just overwrite the default files.
It also includes the adjustments of the related module and smartsearch that i found on github so maybe not so usefull for others.
Edit removed Download zip attachment
« Last Edit: 27.08.2019 13:47:45 by ColinM »